Ara Nguyen

Results 22 comments of Ara Nguyen

@fmeum please feel free to add me as reviewer as I’m actively working on resolving the issues mentioned. It’s still holiday in the US here so I’ll give a more...

update, this is next on my list. I will update by thursday.

@fmeum I was able to reviewed the general idea and manually tested your pr. Your solution seems to be a better idea and a less invasive change compared to what...

@fmeum This looks good and it's ready for import. Sorry for the delay, I was OOO last week.

@guibou `bazelrc` does not have support for shell expansion. We unfortunately do not have plan to prioritize this any time soon. I'm marking this as duplicate of https://github.com/bazelbuild/bazel/issues/10904. Please feel...

What about using varref? I’m not super familiar with it but from the documentation it seems that they can be used in rules that are subject to “Make” variable substitution.

I'm not able to build `rules_cc` on my machine and got this error `ERROR: /Users/aranguyen/rules_cc/examples/custom_toolchain/BUILD:81:19: in cc_toolchain_suite rule //examples/custom_toolchain:legacy_selector: cc_toolchain_suite '//examples/custom_toolchain:legacy_selector' does not contain a toolchain for cpu 'darwin'` If...

@AlessandroPatti is this pr still in progress? There seems to be some failures in the presubmit

@fmeum sure I can help. I have no more capacity this week but I can review next week if that is okay with you.

@fmeum it's on my list. I'm also working on another 6.0 release blocker. Sorry for the delay.