aragonOS
aragonOS copied to clipboard
aragon
(Aragon 1) Reference implementation for aragonOS: a Solidity framework for building complex dApps and protocols
Similar to https://github.com/aragon/aragonOS/issues/493, it would be interesting to have explicit gas cost tests on the following common overhead points in an `AragonApp`: - `isInitialized` modifier vs. without - `auth` modifier...
We could provide a default `initialize()` function as part of `AragonApp` that just calls `initialized()`. This would allow us to recommend all `AragonApp` subclasses to include an `initialize()` block that...
Currently, ACL parameters are created with the `Param` struct: ```solidity struct Param { uint8 id; uint8 op; uint240 value; } ``` but the ACL `grantPermissionP` function takes a `uint256[]` for...
When we talk about kill-switch recoverability we refer to allow DAOs to restore from real bad situations, and probably one of the best examples to think of is switching off...
Make it very, very, **VERY** clear that some roles are more dangerous than others. E.g: - ACL's `CREATE_PERMISSIONS_ROLE`, - Kernel's `APP_MANAGER_ROLE`, - EVMScriptRegistry's `REGISTRY_MANAGER_ROLE`
This is a bit confusing, but once you set a manager to ANY_ENTITY, there is no was to change the manager, or add/revoke permissions. Setting the manager to ANY_ENTITY should...
Currently, permission managers give up control whenever they change management to another entity. It would be nice to have some sort of hierarchy where those higher up can revoke the...
Given the importance of these managers, it may be better to use a [Claimable](https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/ownership/Claimable.sol) transfer instead.
If an `AppProxyPinned` instance is directly registered with the kernel, e.g. in the case of default apps, it can still be replaced via `kernel.setApp()` so it's not really "pinned"
It would be useful if an entity can be granted more than one instance of the permission with different parameters. As @sohkai pointed out to the audit team, this can...
