Apoorv Mishra

Results 21 comments of Apoorv Mishra

This same issue seems to occur to us at one of our production servers. For my case, I think the rate at which server throws the logs at `pm2-logrotate` is...

Hi @amcdnl , millisecond support is already in place, not solely, but when used with seconds in most commonly used time formats(try `npx moment-guess -d '23:00:00.123'`). With epoch, do you...

Hi @vkurko , thanks. I haven't looked at Luxon and don't know much about what it provides. Now that you mention it, I might have a go at it.

Thanks for raising the issue. Needs deeper investigation into why the same regexp behaves differently in different `node` versions.

Hi @JasonYan2015 , that's weird. Could you please also share the following details? - `moment-guess` version(`npx moment-guess --version`) - `node` version - `npm` version - OS

What should `teamLogo` be in `preferences`? URL? Asking so that we can put appropriate validation/assertion in place.

Merged #3857. We can configure choke points :crossed_swords: now :tada:

> The "secret" field should appear on the webhook create/edit form and be user editable and nullable How about restricting it to just _random generation_ as opposed to being editable...

True! As for the approaches, I can't think of any particular reasons to prefer one over the other. Although, I'd like to leave a note on one particular edge case...

Yes, but what if the secret changed while some of the requests with old signature were inflight? Those would fail the verification upon arrival, right? Very very edgy kind of...