Aleksander Smywiński-Pohl

Results 8 comments of Aleksander Smywiński-Pohl

Any update on the status of this pull request?

@leejarvis, me either. But making a proper implementation without it would require a major refactoring I believe. The error detection code would have to be moved to another class, with...

Now it's beautiful IMHO :-) Almost additions only.

1. I can move the tests to already existing files. Yet I think that a test for each type of exception is a good idea - without all these tests,...

Hi, any update on the PR?

I think all changes were done.

@wuarmin it's a good idea - specially in case somebody needs only skinny API. I tried to find it somewhere in the docs, but without success, so a guide extension...

I don't understand the argument against that approach, TBH. This is a builder pattern, which is very common in OOP. E.g. `StringBuilder` in Java uses almost the same idea (you...