Pedro J. Aphalo
Pedro J. Aphalo
Some investigation suggests that `compute_panel` instead of `compute_layer` should be used, as it takes `scales` as argument. Currently _action_ `"spread"` distributes the labels within the range of the `data`. An...
Using `compute_panel` works only if all layers share the same data, at least without implementing a work-around. I ended implementing the ability to use an expanded or contracted range based...
@danielinteractive, you are welcome! Very nice to know that you find the package useful! I am not sure what is the actual coverage of the existing tests, but 20% seems...
@danielinteractive o.k., yes, I see 23%. Several of the functions with 0% coverage have documentation examples that could be used as tests. However, I have been thinking about how to...
I explored a bit the tests in the 'ggplot2' 3.4.0-rc branch. I see `layer_grobs()` used for geoms, while `layer_data()` seems useful for testing position functions and stats. The tests in...
@danielinteractive @sob2021 In branch `quadrant-filter` I am implementing some new functionality in pre-existing functions. I am also adding test cases to cover these changes. I will merge this branch into...
@danielinteractive @sob2021 I have added unit tests that should provide nearly 100% coverage for `stat_dens1d_labels()`. I see with `covr::package_coverage()` and more clearly with `devtools:::test_coverage()` that lines of code that are...
@danielinteractive I have not tried `browser()` and `stop()` yet. But, a quick look shows most if not all code behind `else` statements being ignored when measuring coverage. Code in some...
@danielinteractive I was able to setup the action easily but some of the 'vdiffr' tests produce plots that seem to be different in Ubuntu at GitHub than on Windows 10...
@danielinteractive The coverage workflow is now working, and the package build now includes all tests so that the CHECK workflow also runs them. BFalquet's pull request #23 still needs improvements....