apertium-python icon indicating copy to clipboard operation
apertium-python copied to clipboard

Add multiple spellings

Open ftyers opened this issue 4 years ago • 12 comments

I keep doing analyse() instead of analyze() :(

ftyers avatar Nov 12 '20 22:11 ftyers

Can I take this? Would I need to provide an alternative for the class name too (Analyzer) or just providing an alternative name for analyze (analyse) is enough?

juuz0 avatar Nov 26 '20 17:11 juuz0

Can I fix it ?

b-thebest avatar Dec 04 '20 04:12 b-thebest

@juuz0 I guess that would be better yep.

@b-thebest I don't know, you can try!

ftyers avatar Dec 04 '20 04:12 ftyers

@ftyers I don't find occurance of analyse(), I think its already been done

b-thebest avatar Dec 04 '20 05:12 b-thebest

@b-thebest that's the issue, the code currently has the american spelling (with a z) and it would be nice if it also had the spelling with an s.

mr-martian avatar Dec 04 '20 05:12 mr-martian

@mr-martian So, we need to change occurance of "analyze" ==> "analyse" Is that so?

b-thebest avatar Dec 04 '20 05:12 b-thebest

not simply replace we want both

mr-martian avatar Dec 04 '20 05:12 mr-martian

that is, we want an alias for the function

mr-martian avatar Dec 04 '20 05:12 mr-martian

just providing an alias for the analyze() function name would be easy tho, I did that a few days ago :/ but couldn't find a way to provide an alias to the Analyzer class :/

juuz0 avatar Dec 04 '20 05:12 juuz0

Hello, I just added a pull request to add the aliases for both Analyzer(Analyser) and analyze(analyse), could you please check? :)

juuz0 avatar Dec 04 '20 06:12 juuz0

@ftyers if the issue is not resolved can I work on this issue

max-keviv avatar Apr 18 '21 07:04 max-keviv

@max-keviv there is a PR https://github.com/apertium/apertium-python/pull/87 that I approved, but left a question on that never got answered. So only if you can find other interfaces in need of alternative spellings.

TinoDidriksen avatar Apr 18 '21 08:04 TinoDidriksen