Antoine Pelisse
Antoine Pelisse
Where are the e2e tests that you're trying to run?
> 3. The generated [client-set ](https://github.com/kubernetes-sigs/mcs-api/blob/master/pkg/client/clientset/versioned/typed/apis/v1alpha1/apis_client.go#L75) for this API is being used in the e2etest to create MCS resources ServiceImport and ServiceExport on clusters which have installed the MCS controller...
@ankritisachan is the best person to work on this feature, thanks for taking this!
Yeah, that's ambitious. There's a reason we had written the code the way we did, but let's see what the benchmarks say. You can do ... IIRC ``` go test...
This is what I get: ``` > benchstat master.txt pr.txt goos: darwin goarch: arm64 pkg: sigs.k8s.io/structured-merge-diff/v4/fieldpath │ master.txt │ pr.txt │ │ sec/op │ sec/op vs base │ FieldSet/serialize-20-14 3.369µ...
Can you rename the title of this PR to include `kubectl explain` somewhere? The KEP number is not enlightening enough
Thanks, for me, /lgtm
These look reasonable to me. They're all part of fairly generic package names anyway (pkg/util), so it looks like they are fairly generic. One thing that is important is: are...
cc @alexzielenski
That seems like a very specific use-case, and I could see a verbose recursive version would possibly make more sense IMO, since you would be able to grep tls in...