Anatoli Papirovski

icon location Los Angeles, CA icon location I do things & talk to people, a lot. Node.js Core Collaborator and TSC Member. Work @postmates (he/him)

Results 6 comments of Anatoli Papirovski

Create new github-bot personal access token for nodejs/docker-node and add it to repository secretrs

Approved for @nodejs/tsc

Re-adding Franziska Hinkelmann as a TSC member

+1

Re-adding James Snell as a TSC member

+1

lib: added isNativeError check to assert.js

> I want to ask what kinds of tests can be written for this fix? The actual problem was occuring for frameworks such as Jest. Native code works just fine....

lib: added isNativeError check to assert.js

> Where if the code is now run with Jest, instead of an `AssertionError`, the provided error will be thrown. > > Do I still need to add any tests?...

lib: added isNativeError check to assert.js

Tests for Node.js are meant to reproduce the issue that we saw in another library. Here's a line of code that would fail on the Node.js before this change and...