Daniel Kuts
Daniel Kuts
@Gamrix I fixed some bugs by adding assertions (https://github.com/pytorch/pytorch/issues/77561#issuecomment-1145433818)
@Gamrix I fixed the signed comparison error in assertions. Could you please re-run all workflows to check it? Also there is another PR #77557 that have all checks passed.
> I suppose this is covered by some tests, do these tests work now? If yes, maybe state that in the PR description and enable it in the RUN_ON_QEMU label...
> Yes, remove the guards should be enough for CMake to build the test, then add the test name into [suite/tests/CMakeLists.txt#L6152](https://github.com/DynamoRIO/dynamorio/blob/master/suite/tests/CMakeLists.txt#L6152) and run `ctest -L RUNS_ON_QEMU` see if the test...
> I suppose you’re referring to XINST_CREATE_cmp() and XINST_CREATE_jmp_cond? There won’t be such thing on RISC-V since we don’t have eflags. You can use INSTR_CREATE_beq() to rewrite this part for...
@derekbruening @ksco Disabled unimplemented drwrap-drreg-test, now CI for riscv passes.
@fbarchard @allenkelly @bhbruce @keeranroth, Could you please review PR? Thanks!
> What version of glibc are you using? GNU C Library (Ubuntu GLIBC 2.39-0ubuntu8.2) stable release version 2.39. Yeah, this issue seems the same as #6693, I think it's just...
It wasn't fixed by [#6693](https://github.com/DynamoRIO/dynamorio/issues/6693) at the time I opened issue, but on current master it works fine with Ubuntu24.04.