Arie

We should add unit-tests for api-client based spi classes

2

spi tests that are based on the api-client can provide an `HttpTransportFactory` with a mock `HttpTransport`. For more info see [this](https://developers.google.com/api-client-library/java/google-http-java-client/unit-testing).

Should the formatter also add missing braces

9

To correct any violation of https://google.github.io/styleguide/javaguide.html#s4.1.1-braces-always-used Currently it looks like a code that is formatted like ``` java if (condition) do_something ``` would be formatted (after running the tool) as:...

Integrate Google Cloud Trace integration the runtime.

2

Currently we pass along the incoming `X-Cloud-Trace-Context` header to remote API calls and those are being sent to Google Cloud trace from the appserver. We could use https://github.com/GoogleCloudPlatform/cloud-trace-java (though I...

Instead we should redirect the logs to Google Cloud logging (probably using a dedicated standard Logger).

Is there a reason for using a repacked version of guava

3

see this list: ``` Targets Occurrences of 'repackage' in Project with mask '*.java' Found Occurrences (25 usages found) AppEngineWebXml.java (3 usages found) 19import com.google.appengine.repackaged.com.google.common.base.CharMatcher; 20import com.google.appengine.repackaged.com.google.common.collect.Lists; 21import com.google.appengine.repackaged.com.google.common.collect.Maps; FakeableVmApiProxyDelegate.java (1...

Update appengine-tck to include compatiblity AE Flexible

7

Main TCK repository - https://github.com/GoogleCloudPlatform/appengine-tck/ configuration files should be [here](https://github.com/GoogleCloudPlatform/appengine-tck/tree/master/common/appengine-tck-base/src/main/java/com/google/appengine/tck). Reports available [here](http://www.appengine-tck.org/#/reports.html).