Andrej Ocenas

I pushed a change to the regex. There seems to be the same code in prometheus codebase but would be bit more work to reuse it right now.

@hannahchan I don't think that would solve this. We want to create a valid regext as `||` but we don't want span_name to be treated as regex what ever the...

So it does not seem we use `connection_type` in any way (though maybe it would be nice to use it in some way). So if you have 2 metrics instead...

I agree with @kvrhdn that marking edges in some way to show the request went through some `messaging_system` makes sense to me. Just want to make sure this is the...

Seems like the dependency must be updated on pyro side.

@cyriltovena yes just the version of flamegraph needs to be update in the pyroscope repo.

It doesn't sort on the string value currently (will have to check the version in the app though). It treats `new` as +Infinity and `removed` as `-infinity`. The issue here...

Having a special case for 0% vs 0% diff is easy just wonder what it means in real life. The percentage is percent of total, so having 0% on both...

Updated the PR with some changes related to my comments and also some additional type fixes that I noticed when I seen betterer complain about type assertions.

@timo thank you, you did most of the work anyway :)