pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

Flamegraph: Filter textbox doesn't filter top table

Open cyriltovena opened this issue 1 year ago • 4 comments

What happened?

It seems that when using the filter text box it only highlight flamegraph node and doesn't filter top table which might have been the case before.

What did you expect to happen?

Top table to also be filtered

Did this work before?

I think so, if not I think it could be useful, however you can still click on top table item and hightlight it

image

How do we reproduce it?

  1. Enter a filter in above the text edit
  2. hit enter 3.only flamegraph react,

Is the bug inside a dashboard panel?

No response

Environment (with versions)?

Grafana: 10.3 pyroscope plugin OS: Browser:

Grafana platform?

I use Grafana Cloud

Datasource(s)?

Pyroscope plugin

cyriltovena avatar Feb 08 '24 16:02 cyriltovena

@cyriltovena please add one or more appropriate labels. Here are some tips:

  • if you are making an issue, TODO, or reminder for yourself or your team, please add one label that best describes the product or feature area. Please also add the issue to your project board. :rocket:

  • if you are making an issue for any other reason (docs typo, you found a bug, etc), please add at least one label that best describes the product or feature that you are discussing (e.g. area/alerting, datasource/loki, type/docs, type/bug, etc). Our issue triage doc also provides additional guidance on labeling. :rocket:

Thank you! :heart:

grafanabot avatar Feb 08 '24 16:02 grafanabot

Seems like the dependency must be updated on pyro side.

aocenas avatar Feb 12 '24 09:02 aocenas

Thank you so it is supposed to work ?

cyriltovena avatar Feb 13 '24 20:02 cyriltovena

@cyriltovena yes just the version of flamegraph needs to be update in the pyroscope repo.

aocenas avatar Feb 14 '24 13:02 aocenas