Kurnianto Trilaksono

Results 19 comments of Kurnianto Trilaksono

Hi can I take this one? @javiertoledo

Thank you Javier, could you describe briefly how user can fix the issue? @javiertoledo

Hi @charles-chenzz, are you planning to continue this PR? Let's add some test to validate your implementation

Hi @jbury thanks for your contribution! Please add more meaningful comments to the test :)

> The changes look good to me. Looks like this test is failing in the CI for this PR. Can it be fixed? Hi @varshaprasad96, It is expected to be...

> Hi! I think Kubernetes only imports below three packages. So we need to check only the below packages. https://github.com/kubernetes/kubernetes/blob/f07b47c3d1e596f53640285afb0d53a81fe6f259/go.mod#L232-L234 Noted, thanks for pointing it out

FYI, the check meant to be fail because we do have unwanted dependencies :)

> GOWORK=off go mod graph | grep viper Hi @koba1t, thank you for checking and finding this, I have found a logic error on `line 83`, which supposed to detect...

> Thanks for your great work, @antoooks! > > But I'm still concerned that the `unwanted-dependencies-check` is still down... Maybe you need to look at `"status.unwantedReferences" in the `hack/unwanted-dependencies.json` file....