Anton Verburg
Anton Verburg
If the PID regulator based uppon this idea: https://github.com/home-assistant/architecture/issues/347 has been implemented (I'm currently working on that), you will automatically have a generic regulator, that also can be used as...
In my CV system I also have some water pumps. They have PWM input to set speed. What I do to control them is to use an analog_output platform (see...
> We can not just add this here without tests @emontnemery: are the pytest pipes from github sufficient?
> @jbouwh: seems like you complete implemented your own reload service for mqtt, is that correct? Feels for me that for a simple integration one should not be forced to...
@jbouwh: I have removed this line in __init__.py from mqtt: ``` # Reload the legacy yaml platform to make entities unavailable await async_reload_integration_platforms(hass, DOMAIN, RELOADABLE_PLATFORMS) ``` Seems to me that...
@jbouwh : Results (428.36s): 1429 passed / 2 xpassed. Seems OK.
@emontnemery : Code coverage fails, due to 1 added line not tested. Will add that test in #92996. Should I add it also to this pull request?
> Looks like the line you removed can be cleaned up. It was used to disabled entities that were set up through platform set up. I can open a separte...
> #93588 I will do a rebase to dev after that pull has been merged.
> Please add tests which show this work as intended, I would suggest to add or extend tests in `tests/helpers/test_reload.py` Done in [#8a63eb](https://github.com/home-assistant/core/pull/93538/commits/8a63ebff865640c3e671fbc951cd49a13a3271c2)