Antonio Leiva
Antonio Leiva
Just for consideration. Methods that take a boolean as default are a bit confusing, because one never knows what's the default. This one is specially confusing, as the gut feeling...
Booleans tend to be confusing for method arguments in general, that was point of my suggestion. There's quite some literature about it: https://martinfowler.com/bliki/FlagArgument.html But I also see your point, people...
Agreed, was a random idea, but true that consistency wins in this case.
> As @antoniolg mentioned that would be mainly used in Adapters where we want false Must say that I use it a lot too in custom views, where the value...
> Not sure if that's very useful, but I don't really see why not In my experience, it's helpful in adapters, where you need to use the result of the...
Yup, as we talked, if you want you can take care of this.
Yeah, the README is wrong. Feel free to fix it if you want, or I'll do it in the next days.
Ey, sorry for not telling you anything about this. I´ve been a bit busy these days. First of all, thanks for your great work! I still need some time to...
Sorry, I'm not merging this until 3.0 is in a stable release.
It comes from the `forecastList` that is passed to `with`: https://github.com/antoniolg/Kotlin-for-Android-Developers/blob/678f3f381c6dc5d5176acbdb7c28916b6c1b34fd/app/src/main/java/com/antonioleiva/weatherapp/domain/model/DomainClasses.kt#L3