Anthon Lockwood
Anthon Lockwood
Thank you for the review! In AvcConfig the `sps_info_` member is initialized to `NULL`. You should not access it if `is_ok == false`. Same for `Codec` and its `avc_config_`. It...
If you have the time for this feel free to open a pull request. I would be happy to merge them.
Until @ponchio merges this PR I will keep it up as as "hard fork". Use C++14 and tabs for indentation otherwise [google's C++ style](https://google.github.io/styleguide/cppguide.html). You tested `untrunc good.mp4 good.mp4` on...
@mqudsi I am unable to reproduce this with `N-93826-gab648f79c8`. For further discussion please open an issue on my fork!
> I would guess this is an issue with the audio track - are there alternative libraries to compile against? I once tried 'fdk-aac', but it requires known audio sample...
As I understand it: * sample1 := orig_ok | fileOk | fileBad | result | | ------------- | ------------- | ------------- | | orig_ok | orig_ok | ok | |...
I made some commits recently which try to better support >2GB files. See [here](https://github.com/anthwlock/untrunc) and let me know if it works.
Hi, untrunc needs to somehow know the length of each sample. For different codecs there are different ways to find the length. In untrunc the `matchSample` method trys to identify...
Yes, that is correct. After you figured out the bit-stream syntax, you have to tell untrunc 1. how to detect a packet of your codec, given an uchar pointer 2....
I say it can be easy because in the case of `sawb` only three loc were added/changed. Feel free to ask me any questions whenever you don't understand something related...