Cosimo Lupo

Results 756 comments of Cosimo Lupo

I'm late to the party, but it would have been nice if this logic to build meta table were in ufo2ft (by reading from the public.openTypeMeta lib key)

oops stupid me, we already do support that https://github.com/googlefonts/ufo2ft/blob/0cce3d76e5c901c0191750d9a036f4f6fc19174b/Lib/ufo2ft/outlineCompiler.py#L994 (sorry Denis!)

I guess you want to be able to add a meta table directly to an existing binary font, right? Ideally that would be part of the source itself. If there's...

> I didn't know ufo2ft did this already. hehe, even me I had forgotten 😄

As usual, in general, the more you can "upstream", the better! thanks ;)

LOL what about https://forum.glyphsapp.com/t/feature-request-support-for-public-opentypemeta/9039 ?

that link in turn references two related issues https://github.com/googlefonts/glyphsLib/issues/693#issuecomment-890355574 and https://github.com/fonttools/fonttools/issues/2345

> So the only useful part of this is validity checking for the dlng/slng tags. I'm happy to upstream that into ufo2ft if you'd want it, @anthrotype. that'd be nice....

> Maybe we should demand the latest wheel and pip versions in our own requirements. Would that work? no don't do that. Just mention in the Readme that for M1...