Anthony Duong

Results 6 comments of Anthony Duong

@neelnanda-io I've made the change locally, but noticed that only 12 of the models would have `n_key_value_heads`. And when I add ``` if "num_key_value_heads" in cfg_json: cfg_dict["n_key_value_heads"] = cfg_json["num_key_value_heads"] ```...

Oops, I miscounted. 17 models would have `n_key_value_heads` without those additions. I'll just create a PR to update the docs.

I read that, but either of the solutions I wrote would be a better slow solution, right?

Similarly, [the documentation](https://numpy.org/doc/stable/reference/random/generated/numpy.random.uniform.html) for `numpy.random.uniform` says `random.Generator.uniform` "should be used for new code". And a similar thing for the documentation for `numpy.random.randint`, `numpy.random.normal` and `numpy.random.choice`. @rougier I assume you don't...