Nicolas Sornin

Results 5 comments of Nicolas Sornin

Hello @larskanis, It is my first contribution to a Ruby project. I followed conventions I know from my Java background, let me know if something is not "the ruby way"...

Hello Lars, Thank you for your time reviewing this change. I'm aware flattening groups might seem useless if we have a few levels of nesting, but it can become cumbersome...

Hello @larskanis Could you tell me if the change made matches what you wanted ? I'd like this PR merged before going further with our deployment. Thanks Best regards, Nicolas

Hello @larskanis, I hope you are well. Sorry to insist, but can you tell me if you are waiting something from me to get this merged ? No problem if...

Hello Lars, Thank you for your input. I understand your point about generic code and not be bound to MS specifics. I will get my head back in the code...