community.general icon indicating copy to clipboard operation
community.general copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

homebrew: Add force_formula parameter to pass --formula to brew command

Open kitizz opened this issue 10 months ago • 6 comments

SUMMARY

Fixes #8274.

Some formulas have names that are also cask formulas (e.g. docker). When trying to install such a formula, brew prints a warning and returns a non-zero exit code. This causes Ansible to halt and report the failure. By allowing the task to set force_formula, we can sidestep this problem.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

homebrew

ADDITIONAL INFORMATION

kitizz avatar Apr 23 '24 11:04 kitizz

cc @Akasurde @andrew-d @danieljaouen @indrajitr @kyleabenson @martinm82 click here for bot help

ansibullbot avatar Apr 23 '24 12:04 ansibullbot

Odd! As far as I can tell, the third-party-check error doesn't seem to have anything to do with my changes. I'll rebase and try again...

kitizz avatar Apr 24 '24 10:04 kitizz

@kitizz this PR contains the following merge commits:

  • https://github.com/ansible-collections/community.general/commit/035a8d32bb8b76260dcdd726590d4c33614798c8

Please rebase your branch to remove these commits.

click here for bot help

ansibullbot avatar Apr 24 '24 11:04 ansibullbot

The third-party-check always fails, please ignore it. But you're having some strange unrelated commits / changes in your branch now.

felixfontein avatar Apr 25 '24 05:04 felixfontein

Yup, apologies for that. I have muscle memories from previous rebase workflows that were different 😅 Should be good now...

kitizz avatar Apr 25 '24 21:04 kitizz

Looks good to me! Will merge in ~a week if nobody objects.

felixfontein avatar Apr 28 '24 12:04 felixfontein

@kitizz thanks for your contribution!

felixfontein avatar May 04 '24 13:05 felixfontein