Asbjørn Nilsen Riseth

Results 37 comments of Asbjørn Nilsen Riseth

I also think that the `c1` etc. should be passed on to `GradientCache` in these two functions. https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/blob/master/src/gradients.jl#L108 https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/blob/master/src/gradients.jl#L134 Or have I misunderstood something here?

> Hmm, I made a change to c1 but does it actually need to be required here? Thanks. There's also a reference to `df` on this line https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/blob/master/src/gradients.jl#L72 I don't...

Does the build script not check whether a package is installed before calling apt? I have the same issue on the system at my university. Calling Pkg.build in the REPL,...

~I think the Counter part is covered by https://github.com/JuliaNLSolvers/Optim.jl/blob/ac1ab5c9799d29cef8f57ddab54696a1ea318779/test/general/counter.jl~ Oh, forget it. The Optim tests are only checking a subset of the line search algorithms.

`hagerzhang!` has verbosity options via the `display` parameter: https://github.com/JuliaNLSolvers/LineSearches.jl/blob/master/src/hagerzhang.jl (I don't know exactly how the bitwise operations work, this was created long before my time with the package) It doesn't...

Hehe, yes it looks like a remnant of the original FORTRAN(?) code. I tried to enable display a year ago, but gave up as I didn't know what datatype to...

> let’s see if we can’t I hope we *can* :) Edit: I now realise that the redundant negative was probably intended :laughing:

- [x] Add `dphi_0_previous` as an update-able value in `InitialConstantChange`, so that we can remove it from `state` in Optim. EDIT: fixed in https://github.com/JuliaNLSolvers/LineSearches.jl/pull/112

> Maybe for starters just a basic example given a f, x0 and a search direction g? That's a good idea. The examples can be copied from the test files....

We are in the middle of transitioning the code to a more "non-Optim-friendly" API. See #90 It should be quite straight-forward to introduce some examples for usage when we are...