LineSearches.jl icon indicating copy to clipboard operation
LineSearches.jl copied to clipboard

TODO: New LineSearches

Open pkofod opened this issue 6 years ago • 1 comments

ref changes in https://github.com/JuliaNLSolvers/LineSearches.jl/pull/80

  • [ ] Don't allocate vectors. We might as well have them as scalars to avoid allocations
  • [x] We should also free the deepest layer of df, although we could in theory still provide simple wrappers.
  • [ ] Add an argument to specify a largest \alpha. This is to accommodate Fminbox and other simple constrained optimizers not evaluating outside of constraints. Of course, some constrained optimizers will need more specialized line searches (or use trust regions of course).
  • [x] We should return \alpha, \phi(\alpha) to avoid recalculation of \phi if packages other than Optim and NLsolve want to use these functions. We can still call value_gradient! outside, as we're checking if it's the same point anyway. ... more?

pkofod avatar Mar 03 '18 07:03 pkofod

  • [x] Add dphi_0_previous as an update-able value in InitialConstantChange, so that we can remove it from state in Optim.

EDIT: fixed in https://github.com/JuliaNLSolvers/LineSearches.jl/pull/112

anriseth avatar Apr 05 '18 14:04 anriseth