Yagiz Nizipli comments

Results 450 comments of


                                            Yagiz Nizipli

src: replace splitstring with built-in

> ✘ Last GitHub CI failed The GitHub UI is showing wrong labels. Jenkins CI passes. What is the proper action in this step? @nodejs/build

src: replace splitstring with built-in

> The only way to remove this check would be to rebase. The job was removed as part of the macOS update to 13 Would it be appropriate to land...

src: replace splitstring with built-in

> That's what I would do Cc @nodejs/tsc due to the removed ci job, I have to land this manually (to avoid re-running the whole CI one more time). Please...

fix: add `ignore-date` when rebasing

cc @targos @aduh95 appreciate if you could take a look at this

Adding `is_base64(const char*, size_t)` API

cc @lemire

Adding `is_base64(const char*, size_t)` API

Workerd has a similar usage. ``` // Determine if the data is base64 encoded kj::Array decoded = nullptr; if (isBase64(unparsed)) { unparsed = unparsed.first(KJ_ASSERT_NONNULL(unparsed.findLast(';'))); decoded = kj::decodeBase64(strip(jsg::Url::percentDecode(data.asBytes())).asChars()); } else {...

Yagiz Nizipli

src: replace splitstring with built-in

src: replace splitstring with built-in

src: replace splitstring with built-in

fix: add `ignore-date` when rebasing

Adding `is_base64(const char*, size_t)` API

Adding `is_base64(const char*, size_t)` API

Adding `is_base64(const char*, size_t)` API

Proposal: Alternative to enabling Corepack by default

Should node support subcommands?

Minor regression in types params names with `4.20240903.0`