Brad Jorsch
Brad Jorsch
The action does do one more request than necessary, in that it fetches pages of files until getting a page with zero results instead of using [Octokit's pagination](https://octokit.github.io/rest.js/v18#pagination) that detects...
@dorny Ping?
No. We're running it on pushes to master, pull requests targeting master, and a weekly cron. But since most of our pull requests target master and most of our pushes...
I don't know how osd_cat works, but xtrace does report it's doing a SHAPE-Request. xtrace excerpt ``` 000:
> I'm not sure if `**folder` is a rule of gitignore or only a side effect of git. It looks to me that this sentence from https://git-scm.com/docs/gitignore is relevant: >...
@gsherwood FYI, we're now making use of this patch in production in our monorepo at https://github.com/Automattic/jetpack. It'd be nice if this could get reviewed.
@gsherwood We've been using this in production in our monorepo for three months now. It seems to work well.
@jrfnl Would you clarify? I tried to avoid having a BC break in here by making the filter have to specifically request the new behavior. Or is it the thing...
@jrfnl How's it look to you now?
> If this PR makes it easier to support outside of PHPCS, then I'm happy to consider that for inclusion sooner, but I have not looked into the purpose of...