anne-glerum
anne-glerum
Talking to Juliane yesterday, we do the calculation of the residual before solving so that we can use the already assembled matrix and rhs based on the previous solution. We...
Fix: add substitution in contrib/utilities/jsontomarkown.py
@cedrict Are you sure you pushed your latest changes? My comments have not been marked 'outdated'.
Hi @gassmoeller , yes I can see that makes reviewing very complicated. I rebased to the release because that is the version we wanted to use for the paper. I...
> > I can make a copy of this branch (based on the release) and then rebase this PR to main. Would it be okay if I squash my commits...
Hi @gassmoeller, I have rebased to main. I also ran the third benchmark (2D square under simple shear for half of the model time) again; I summarize the results below....
ad. 6. Could one difference between the particle and the field runs lie in the reaction_term? It computes the spin tensor W from the solution of the previous timestep, but...
Ohhh brilliant @gassmoeller! Thank you for taking the time to figure this out! Concerning option 3, we would need access to the `old_solution` at the location of particles to compute...
We've been discussing the options you have suggested above in our meeting yesterday, and came up with some potential ways of implementing the third option. Here's how I see it...
> Option 2 sounds the most appealing to me, because it introduces the least amount of specific code into main ASPECT and almost all new code can go into the...