Ankush Menat
Ankush Menat
@barredterra refresh branch?
I don't think it was ever designed for dialogs. This is a feature of form/doc grid.
This is only used in one table on workflow, feel free to send PR.
> A better design would be a configurable option on the doctype as to whether or not root-level documents can be deleted. IMO this should just be allowed by default....
re: github wiki - [x] Migrated / added redirect for related "documentation" worthy pages. - [x] Deleted obsolete and misleading docs from wiki. Lots of old code and guides that...
Not sure why these unrelated failures are there, re-run the tests after merging develop? 🤔
It's already there: https://frappeframework.com/docs/v13/user/en/rate-limiting
have a look at implementation, it's on user/ip: https://github.com/frappe/frappe/blob/develop/frappe/rate_limiter.py
> I finally just replaced Status by Sender so why does the semantic test fail ? You're supposed to follow https://conventionalcommits.org/ guidelines for all commits, anyway we can just squash...
Duplicate https://github.com/frappe/frappe/issues/17793