Ankush Menat

This is security critical, we are not accepting any community PRs. This issue is just opened for tracking the issue.

This isn't burning issue, passlib seems to be able to work in absence of crypto.

TODO: - [ ] test communication crafted using this - [x] test pdf crafted using this

@marination this doesn't work afaik We use cookies from current request and pass it to wkhtml so it can read private images. However when it's done from background jobs it's...

update: working on base64-ing private images rn. Once we have this it's easier to port this change without breaking anything. https://github.com/frappe/frappe/pull/24980

the world of email is :hankey: https://sendgrid.com/blog/embedding-images-emails-facts/

forced sync from crowdin. (project > integration > sync now)

or limit roles on oauth client

https://github.com/frappe/frappe/pull/26193

@Mutantpenguin can you verify if this change is fine for your usage too :eyes: don't want to break it again while fixing this.