Ankush Menat

Results 243 comments of Ankush Menat

https://github.com/frappe/erpnext/blob/7d22df2af59f5dfd666d87bce3f192d3b35adde6/erpnext/accounts/report/general_ledger/general_ledger.py#L457-L460 Report shouldn't be translating here ig.

This whole function is pointless. It's checking for existence of truthy value in row, what if I want it to be falsy like checkbox or numbers with 0. :hankey: IMO...

opened PR to remove this: https://github.com/frappe/frappe/pull/26269

![image](https://github.com/frappe/bench/assets/9079960/993ab697-e97d-4a67-9019-2c2047ded9f2) 1.5 mil request with response, 0.5mil more with 304 on FC. EVERYDAY! :rofl:

User wise configurable columns are a separate feature IMO. Even desktop view doesn't support it, so lets first focus on this :+1:

@Olawale1 that same thing works in mobile too, it's not mobile specific configuration. @safwansamsudeen can you confirm first first 3 fields are picked based on same configuration? :thinking:

@safwansamsudeen the test failures are likely related. See list view ones, I'll check the others. Test file is ins cypress/integration if you can reproduce locally that most likely means something...

@safwansamsudeen last bit of alignment and UI problems left ![image](https://github.com/frappe/frappe/assets/9079960/0eae27f7-2183-445d-8c9b-c9ebdf141f44)

@safwansamsudeen the alignment is still kinda broken :smiling_face_with_tear: before: ![image](https://github.com/frappe/frappe/assets/9079960/a74af94b-8c8f-483b-9888-3280637e6c14) after: ![image](https://github.com/frappe/frappe/assets/9079960/55ff7ac1-1be7-4945-9784-29309c7c2eae)

Closing since multiple UI inconsistencies still and there's parallel project going on for UI rewrite