Ankur Shrivastava
Ankur Shrivastava
https://github.com/carousell/Orion/pull/118#issuecomment-1201974988 I agree with @anaghsys
I think its better if we move `if defaultLogger == nil ` inside `once.Do` What do you think ?
My concern is that init() is always called, so if we import a package that has an init function, it will be executed. Since Logger is used by a number...
Also the proper use of Logger was intended in the way where you call GetLogger() and then use that object everywhere in that scope
Agreed, will take it up once orion is feature complete! Please feel free to contribute till then
Kapeel, this is most likely because of missing vendor package, can you update your vendor and check ?
shouldn't you just change logfields to sync.Map instead ? something along the lines of - https://github.com/go-coldbrew/log/pull/5/files