Ankur Goyal

Results 106 comments of Ankur Goyal

Awesome, let me clean everything up, and update the tests as well. I agree, there's a lot more to do, and I'll keep the momentum going in follow up PRs.

@NielsRogge @Narsil @sgugger @patrickvonplaten I think we are pretty much there -- I just updated to address the outstanding comments, and the failing tests look like they are flaky (unrelated...

Thanks @sgugger. Should I open one issue with all of them or a separate issue for each TODO? Happy to do that.

Here is the task with follow ups: https://github.com/huggingface/transformers/issues/18926.

I just hit this on Linux (Ubuntu 20.04) as well: ``` $ cat /etc/*release* DISTRIB_ID=Ubuntu DISTRIB_RELEASE=20.04 DISTRIB_CODENAME=focal DISTRIB_DESCRIPTION="Ubuntu 20.04.5 LTS" NAME="Ubuntu" VERSION="20.04.5 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.5 LTS"...

Yes just clarifying since it was 2 years ago :). I'll dig further, thanks for the quick reply.

I had a bit of discussion with @NielsRogge about this. The model type here is different because this model actually has a slightly different architecture than standard LayoutLM (it has...

@NielsRogge and @osanseviero just following up on this, we made the necessary changes in https://github.com/impira/docquery to keep the model working both in transformers directly and DocQuery, so at least from...

@osanseviero I believe this issue should be closable now (your original repro should now succeed). But please let me know if you see otherwise.

Are you aware of any workarounds to this in the meantime? I tried using custom Javascript but I think due to shadow DOM issues was not able to reference another...