Ankur Goyal

Results 106 comments of Ankur Goyal

@Narsil I've left a few TODOs -- (1) supporting tensorflow, (2) filling in docs, (3) filling in tests -- which I'll gladly do. I just wanted to post sooner than...

@NielsRogge @Narsil gentle nudge on this PR. I plan to fix the tests + write docs as a next step but wanted to get some quick feedback about whether this...

Thanks @NielsRogge! We're discussing the pipeline part in [pull request 18414](https://github.com/huggingface/transformers/pull/18414). Would love your feedback there too!

@NielsRogge @Narsil I just updated it to include tests+documentation. If it's okay, I'd like to defer the tensorflow implementation for now (due to some personal lack of familiarity). I am...

@NielsRogge @Narsil, I went ahead and implemented support for TensorFlow and the checks are now passing. Would appreciate a re-review.

@NielsRogge gentle nudge on this PR :)

> Thanks @NielsRogge! I just updated with your comments, added to the list of doc tests, and verified locally that they are (now) passing.

Up to you guys on that one!

@NielsRogge @Narsil I did some thinking over the weekend and think it makes sense to include them in `AutoModelForQuestionAnswering` to be consistent with `LayoutLMv2` and `v3`. We can move around...

@Narsil @NielsRogge did you have any further questions on this PR, or is it ready to merge in?