Antti Korpi

Hi, user here. Drivebying with a lightning review. Things that made me think: - Could you describe in English what exactly is wrong that you're attempting to fix? - What...

What would the `diff` call in your example code return? I don't understand yet what "filter" means in this context.

I see! I played with [some possible workarounds in this Observable notebook](https://observablehq.com/@anko/an-exploration-of-current-ways-to-ignore-certain-keys-when-d) trying to see if any of them sound good. Performance-wise, none of them would be as good as...

Random reactions from someone who's stared at this library quite a lot: - - - > When I compare two arrays: > 1st arg = ['a', 'b', 'c'] > and...

On extra details: [`.detailedDiff`](https://github.com/mattphillips/deep-object-diff#detaileddiff) separates additions, changes, and deletions: ```js > dod.detailedDiff({a:1, b:2, c:3}, {a:2, b:2, x:42}) { added: { x: 42 }, deleted: { c: undefined }, updated: {...

I think this is by design. How should your expected diff be applied to `['a', 'b', 'c']` to get `['b', 'c']`? If the `deleted` property corresponds to the `delete` operator,...

What is the problem here? Bigger inputs take more time to process, and `detailedDiff` is the most expensive type of diff operation. Such an operation taking a while to process...

Simpler workaround: ```js const result = detailedDiff(oldItem, newItem); const areSame = Object.values(result) .every((obj) => Object.keys(obj).length === 0); ``` I like this idea. The internals could determine this basically for free...

It's because the keys of your 4-element array are the indexes 0–3, and none of them go away, they just change to contain different values. In other words, the sequence...

I don't want to add run-time type checks. In a dynamically typed language, I think the only sane way to go about writing a library is to assume the user...