ankitkapur comments

Results 6 comments of


                                            ankitkapur

Remove unused variables in OfflineStorage_Room.cpp and HttpClient_Android.cpp

auto result_count = env->GetArrayLength(java_records); change to size_t

Remove unused variables in OfflineStorage_Room.cpp and HttpClient_Android.cpp

remove static constexpr char newRecordSignature[] = "(JIIJIJ[B)Lcom/microsoft/applications/events/StorageRecord;";

Remove unused variables in OfflineStorage_Room.cpp and HttpClient_Android.cpp

remove int persist_lb = static_cast(EventPersistence_Normal); int persist_ub = static_cast(EventPersistence_DoNotStoreOnDisk);

Remove unused variables in OfflineStorage_Room.cpp and HttpClient_Android.cpp

remove size_t index = 0;

Fix CMakeLists.txt for Android builds

list(APPEND SRCS pal/posix/NetworkInformationImpl.mm # TODO: this unit below needs to be deprecated and removed ../third_party/Reachability/ODWReachability.m ) //Add this elseif block elseif(ANDROID) list(APPEND SRCS http/HttpClient_Android.cpp http/HttpClient_Android.hpp pal/posix/NetworkInformationImpl.cpp ) else() list(APPEND SRCS...

Fix CMakeLists.txt for Android builds

Add this OR if(PAL_IMPLEMENTATION STREQUAL "WIN32" OR ${CMAKE_SYSTEM_NAME} STREQUAL "Android")