Andreas Gullberg Larsen

Results 259 comments of Andreas Gullberg Larsen

@lipchev > Ah, damn it- I just re-read what I wrote last night, realizing that the equality contract is still broken- due to the lack of transitivity (again).. If we...

Hi, this is a known issue: #965 Due to a large number of types and type members for all our 100+ quantities and 1000+ units, the JIT spends a long...

@Jens88 I'm not sure, we added a bunch of units for sure, but 100x sounds a lot. Are you able to profile the difference between the two? Maybe find what...

@Sigvess92 Sorry for the late reply, I have been missing out on email notifications for some time. I think Impulse is a great fit, please go ahead with the PR....

Sounds like a good improvement as long as it compiles for nestandard2.0. These structs were intended to be immutable already. Would you be interested in attempting a pull request @sonnemaf...

No rush on my end :-)

@sonnemaf Sorry for the friction. You need to install Git LFS to clone the repo. https://git-lfs.github.com/ LFS is nice when it works, but GitHub charges for it when monthly bandwidth...

Sorry for the late reply, I have been missing out on email notifications for some time. Will review soon.

@bitbonk An early prototype here to explore how it can be used. #984 I haven't yet looked into what the changes were compared to the experimental interfaces at the time,...

I'm having similar trouble with all 4.x versions. Repro on master branch: https://github.com/angularsen/roslyn-analyzers/ Rider 2022.2.3 VS2022 17.3.4 dotnet SDK 6.0.401 `Microsoft.CodeAnalysis.Analyzers`: 3.3.3 `Microsoft.CodeAnalysis.CSharp.Workspaces`: below versions ### Repro - Change `Microsoft.CodeAnalysis.CSharp.Workspaces`...