UnitsNet icon indicating copy to clipboard operation
UnitsNet copied to clipboard

Use readonly for structs in QuantityGenerator #1130

Open Brunni opened this issue 2 years ago • 1 comments

Fixes #1130

https://docs.microsoft.com/en-us/dotnet/csharp/write-safe-efficient-code#declare-immutable-structs-as-readonly

Force the compiler to check, that all fields are readonly as well.

Brunni avatar Sep 10 '22 10:09 Brunni

Codecov Report

Merging #1135 (714ddb4) into master (b480558) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1135   +/-   ##
======================================
  Coverage      85%     85%           
======================================
  Files         322     322           
  Lines       52322   52322           
======================================
  Hits        44894   44894           
  Misses       7428    7428           
Impacted Files Coverage Δ
...nitsNet/GeneratedCode/Quantities/Acceleration.g.cs 87% <ø> (ø)
...et/GeneratedCode/Quantities/AmountOfSubstance.g.cs 87% <ø> (ø)
...tsNet/GeneratedCode/Quantities/AmplitudeRatio.g.cs 82% <ø> (ø)
UnitsNet/GeneratedCode/Quantities/Angle.g.cs 87% <ø> (ø)
...tsNet/GeneratedCode/Quantities/ApparentEnergy.g.cs 81% <ø> (ø)
...itsNet/GeneratedCode/Quantities/ApparentPower.g.cs 82% <ø> (ø)
UnitsNet/GeneratedCode/Quantities/Area.g.cs 89% <ø> (ø)
UnitsNet/GeneratedCode/Quantities/AreaDensity.g.cs 77% <ø> (ø)
.../GeneratedCode/Quantities/AreaMomentOfInertia.g.cs 83% <ø> (ø)
UnitsNet/GeneratedCode/Quantities/BitRate.g.cs 89% <ø> (ø)
... and 106 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 10 '22 12:09 codecov[bot]

Sorry for the late reply, I have been missing out on email notifications for some time.

Will review soon.

angularsen avatar Oct 31 '22 21:10 angularsen