Angelika Tyborska

Results 41 comments of Angelika Tyborska

I also had this issue. Mounting a `DragDropContext` component anywhere rendered useless all the `onDragOver`, `onDragStart` and `onDragStop` listeners I had on my other components. What worked in my particular...

@zorn You're absolutely right. This existing code with the comment in the tests should never have been added: ```elixir # run test synchronously to be able to use the same...

> Happy to update/change the PR to remove that little snippet That would be much appreciated!

An example of an exercise that might be problematic for the test generator: `kindergarten-garden` implements a few test cases from `tests.toml` in a single `test` block: https://github.com/exercism/elixir/blob/4ab39ca23e6a3f04548ba6bd41056b55ef605ea9/exercises/practice/kindergarten-garden/.meta/tests.toml#L20-L30 https://github.com/exercism/elixir/blob/4ab39ca23e6a3f04548ba6bd41056b55ef605ea9/exercises/practice/kindergarten-garden/test/garden_test.exs#L42-L57

> Is there any guarantee that all the tests in tests.toml have been implemented? There is a guarantee that a test in `tests.toml` will be defined in `canonical-data.json`, but not...

(Note: I'm leaving a short, not well-research opinion first, to kick off a discussion with other maintainers) Hmm, I'm not entirely sure how to feel about this idea. On one...

I did a quick check in the test runner (commit https://github.com/exercism/elixir-test-runner/commit/b1ade5c98160364163e63e2d6eb7c2b21502db62 based on Jie's unmerged work in https://github.com/exercism/elixir-test-runner/pull/86, command: `./bin/smoke_test.sh`). It doesn't work in the test runner. The new test...

Great! If we can make the tests pass without modifying the test runner like Jie says, and is Jie likes the idea of the doc tests too, then I think...

Just FYI, I think it's this bug: https://github.com/elixir-lang/elixir/issues/9601 Fixed in https://github.com/elixir-lang/elixir/commit/bae1cc7cdf1a5beb27530ff8d85869e4c845cda6 which was part of 1.10, but not lower

> It fails in Elixir 1.8 and 1.9, and succeeds in 1.12 and 1.13 (1.10 has been hanging for 17 minutes, not a good sign). I tested in the official...