Lukasz Anforowicz

Results 110 comments of Lukasz Anforowicz

This PR replaces https://github.com/image-rs/image-png/pull/421. (This PR can be seen as a non-breaking-change alternative of the other, earlier PR.)

> @anforowicz could you resolve the conflicts? Ack. I'll do that later today. My apologies for missing this message earlier. > There doesn't seem to be any reason not to...

I have rebuilt the benchmark on Linux, after adding `rustflags = ["-Ctarget-feature=+sse3"]` to Chromium's `//build/config/compiler/BUILD.gn`. Full command-line can be found at the end (*). This didn't change the results on...

FWIW, here is `rustc --version` output from my build system: ``` $ third_party/rust-toolchain/bin/rustc --version rustc 1.86.0-dev (ad211ced81509462cdfe4c29ed10f97279a0acae-1-llvmorg-20-init-17108-g29ed6000 chromium) ```

> the big questions to ask are > > * does any of this interact with `repr(C)` types? those have different platform-dependent layouts No - there are no `repr(C)` in...

> I diffed the asm for unfilter_paeth3, unfilter_paeth_u8, and unfilter_paeth6 for x86_64-unknown-linux-gnu, x86_64-pc-windows-gnu, and x86_64-pc-windows-msvc and there are zero differences other than a couple extra calling-convention related moves on windows...

> [@anforowicz](https://github.com/anforowicz) I would appreciate if you could benchmark that change on the machine and corpus where you observed the regression I've added a comment at https://github.com/image-rs/image-png/pull/574#issuecomment-2669499437

> @anforowicz @HeroicKatora Do you have a suggestion for a better interface for configuring animation encoding? > > https://github.com/image-rs/image-png/blob/4b10bf8313c7a7db1aebc3cb8f18c0e922429547/src/encoder.rs#L146 Not really, sorry. From my perspective, the highest priority requirement is...

> This PR changes the decoder from **pulling** fixed size 32KB chunks of input data to having the caller **push** arbitrary sized chunks of data into the decoder. The default...

@fintelia - could you please upload your benchmarking setup to a github repo + point out the hashes of the before/after commits? This would help me understand what is being...