Lukasz Anforowicz
Lukasz Anforowicz
> One difference would be the use of Seek to expose a more flexible API. This sounds good. `&u8` alone doesn't implement `Seek`, but one can always wrap it in...
> `StreamingDecoder::update(buf)` could have an early check that if `buf.len()` is large enough, it goes through to the state machine with borrowed data, and if it isn't large enough, then...
> > The main challenge here is that as long as the scratch buffer is not empty, it needs to be consumed first > > I'm not planning to support...
Hmmm... after having already submitted the PR, I _now_ started to wonder: * Maybe the remaining API should just be called `next_row` (rather than `next_interlaced_row`) * Maybe I should simplify...
One motivation for the changes in this PR is to improve the performance of `image::codecs::png::PngReader` which [calls](https://docs.rs/image/latest/src/image/codecs/png.rs.html#68-90) into `next_row`. Changes to `next_frame` wouldn't help with that. It _seems_ that sometimes...
Is the main concern the desire to avoid breaking changes? One way to address this concern may be to instead add a new API (`next_row2`?) and the [`#[deprecated]`](https://doc.rust-lang.org/beta/reference/attributes/diagnostics.html#the-deprecated-attribute) attribute to...
> The goal is to bundle all the breaking changes we'd like to make into a single `0.18` release, rather than have a couple breaking releases in rapid succession. >...
Status update: * I've made the small tweaks that I've listed in https://github.com/image-rs/image-png/pull/421#issuecomment-1789923399 * I've put together a PR for another breaking API change (`BufRead`): https://github.com/image-rs/image-png/pull/427 * I am no...
@fintelia, can you PTAL again? # Process notes I see that this PR [has been rebased](https://github.com/image-rs/image-png/pull/421#event-11547577738) on top of https://github.com/image-rs/image-png/tree/next, but this branch is 24 commits behind https://github.com/image-rs/image-png/tree/master and this...
> I'm supportive of this PR, but I'm too burned out right now to review everything and manage a major release. As far as the `BufRead` changes, the last `image`...