Andrey Fedotov

Results 25 comments of Andrey Fedotov

Hello, in my case there is a hang too. Here is the code to reproduce: ```Rust use goblin::{error, Object}; use std::path::Path; use std::env; use std::fs; use goblin::elf::header; fn main() ->...

Well, I Iooked. This [function](https://github.com/rust-lang/rust/blob/master/library/core/src/str/validations.rs#L127) does validation of utf8 strings in std. We could put this code in `src/archive/mode.rs` and do validation before calling `buffer.pread_with::`. Another way we could do...

Hmm, that's weird... Here is the stack trace ``` Running: /fuzz/parse-out-old/casr/cl1/crash-c4db1c20345db68536fb2ba80131565aa5aec496 thread '' panicked at 'byte index 3 is not a char boundary; it is inside 'Г' (bytes 2..4) of...

Yes, you are right, readability will suffer if we add some checks. My idea was to stop parsing and return an error if overflow occured. But if we couldn't say...

> The only way I can see that overflowing is if `file_alignment` is not a power of 2. Is that what your Sydr checker found? Sydr, somehow could overflow `file_alignment`....

> I'm not sure what you mean by dangerous. I mean, that there is no panic in release. Maybe return value of the function is checked by caller. > However,...

The alignment factor (in bytes) that is used to align the raw data of sections in the image file. The value should be a power of 2 between 512 and...

> @anfedotoff i'd be ok with merging this but i think we have to roll back the breaking change to the `find_offset` function; it seems unnecessary to me. If you...

> @anfedotoff Ok that works for me! I've done something strange, playing with git history and doing rebase master. I'll better reopen new PR from fresh master. Fix will be...

I have the same problem. ``` ERRO[0413] error waiting for container: unexpected EOF ERROR:root:Executed command: "docker run -ti --rm -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/experiment-data:/tmp/experiment-data -v /tmp/report-data:/tmp/report-data -e INSTANCE_NAME=d-test-local-fuzzbench -e EXPERIMENT=test-local-fuzzbench -e...