Anna Nelles
Anna Nelles
You should get Dave Seckel to review this, but I am not sure that he does code review :D If he is ok with your concept, I would accept this...
@sjoerd-bouma can you fix the conflicts? I think if this is the version from your thesis, we should merge this. It is documented and better than what we had before.
With 8 days on the new job, @lpyras now of course has time to fix this, right? Please don't wait too long. This is an essential module.
I agree with @cg-laser that this is a wild mix of detector parameters and other functions. I don't think they are useful in utilities either. If you want to move...
Otherwise, we should close this PR as is.
@cg-laser this seems like a discussion that once needs to be had during a developers call.
I think the person in question finished their thesis work. If this looks good, @fschlueter go ahead, fix the checks!
I think this looks good now. @nilsphysics could you clean up the merging conflict?
If I am not fully mistaken @cg-laser was the one to introduce tiny_db in here. Maybe it really is too tiny for what we are doing here? I would be...
In the interest of not having dangling pull requests: @sjoerd-bouma are you happy with this now? I think you are the designated person to review this.