Andy Ward

My thoughts on the validity of optionality on the other facet types ✅ = valid ❌ = "useless" - possible audit warning ## Entities | Fields Entered| Required| Optional |...

> The problem with PROHIBITED and PSET/PNAME/DATATYPE/VALUE is, that you most likely do not want to negate the datatype. I get what you're saying now. DataType is slightly different to...

Not sure I understand why we'd require a DATATYPE - even when VALUEs are required. In the majority of the use cases I see the user won't know or care...

Every IDS file has a **Milestone** property in the [metadata](https://github.com/buildingSMART/IDS/blob/master/Documentation/ids-metadata.md). So Milestone should contain your Phase name. This means you'd have multiple IDS files split by phase (& potentially **Purpose**).

Just FYI, I think the [test cases](https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases-material.md) cover pretty much all those scenarios pretty well (although maybe not exhaustively across all permumtations). So 👍 to those who created them. The...

> I don't think we should go as far. I would propose to exclude evaluation of IfcRelAggregates relatedobjects in any facet Yes, that makes sense for me. Agree on all...

1. My understanding is we should check the value at any level in the classification hierarchy (any ancestor). See this [test case](https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases-classification.md#pass-values-match-subreferences-if-full-classifications-are-used-eg-ef_25_10-should-match-ef_25_10_25-ef_25_10_30-etc) 2. URI - This is presumably up to...

Probably needs clarifying in the docs, but my reading on it is that URI is a parameter you'd suggest be could specified by the author/authoring tool, to aid the ultimate...

Hi @mostl33 What have you tried so far? Getting the layers should be a matter of `model.Instances.OfType()`. Getting the products assigned it a bit more convoluted layers are often applied...

Thanks for this - and the update. It looks sensible non-breaking and green lights on tests is good news. I've added one minor review item. I'd like @martin1cerny to review...