Andy Ward

Results 368 comments of Andy Ward

This is just down to the way the IFC schema is defined. IfcTriangulatedFaceSet/IfcPolygonalFaceSet define Coordinates as an `IfcCartesianPointList` (implemented by 2D/3D sub-classes) which stores vertices in a compact form of...

Yes, deduplicating vertices globally would be challenging for a IfcCartesianPointList3D - and I'm not sure how much benefit you'd get? Are you seeing much duplication? Incidentally if you're looking to...

Have reproduced in both WebUI and WindowsUI. Will need deeper investigation. The model validates fine, although technically IfcFaceBasedSurfaceModel is deprecated in IFC4 (i.e. it should be FacetedBrep) Highlighted the rogue...

Hi @r-silveira thanks for the investigation. I'm going to ask @Ibrahim5aad to take a look at this. While your solution may fix this issue I'm not 100% it's addressing the...

This still feels like a bit of a post-fix to the root cause. Now all vertexes will be re-added/rebuilt after the first pass. I think what I'd do is understand...

Sure, it's basically what we do here: https://github.com/xBimTeam/XbimGeometry/blob/c4df872dc60f3f440b10fbb8e624055b34ae68eb/Xbim.ModelGeometry.Scene/Xbim3DModelContext.cs#L813 The underlying OpenCascade (OCC) geometry engine is generally supposed to be thread safe, but that's not to say there aren't edge cases...

Sorry we only have a private nuget repo currently for v6. It's actually simple to build it yourself (and much quicker than the v5 branches in develop / master). Will...

Looks to me that [MultiValueDictionary](https://github.com/xBimTeam/XbimEssentials/blob/master/Xbim.Common/Collections/MultiValueDictionary.cs) is not thread safe. If you wanted to submit a PR replacing the inner `Dictionary` with a `ConcurrentDictionary` that should help. Is it Revit that...