Andy McCurdy

Results 28 comments of Andy McCurdy

Sometimes you do care about the reply values from commands within the pipeline and we need to provide a way to access those values. See the discussion on #730.

This seems like a reasonable suggestion. I'll add it in the next version. Remember that the namespace string will add extra bytes to each key. It might be better in...

@kmerenkov: Check out the consistent_hashing branch in my redis-py repo. I needed a way to detect which arguments in a command were keys just like you do, but did it...

@kazanz your solution only works for commands that deal with exactly one key. Commands like KEYS, SUNION/SINTER, SORT, and others that operate on 2 or more keys would not be...

@etcsayeghr Pull requests are accepted. This is a pretty complicated issue that I personally don't have a need for. You can see some of the complexities here: https://github.com/andymccurdy/redis-py/pull/710#issuecomment-174850384

@Kazanz Hey, sorry I've been away visiting family and friends for the past 8 weeks. When I last looked at this, there were some commands that weren't implemented (`SORT` comes...

@dejlek There's a `retry_on_timeout` option in redis-py that will attempt to reconnect and reissue a command when a timeout occurs. If the command again times out, the timeout is then...

Changing the `sleep_time` to a value greater than `0` seems like a good idea. If I recall correctly, if we set `sleep_time=None`, we'd never get notified if/when the socket dies....

Changing the name to `socket_timeout` makes sense. We'll do that in 4.0 as it's a backwards incompatible change. I'm also fine with increasing the default value, but I'm not quite...

Thanks for the feedback. I'll add this to the redis-py 4.0 TODO list. FYI, 4.0 will be Python 3.5+ only.