Andy Mantell
Andy Mantell
Govuk js is imported dynamically and given names with webpack magic comments as follows: ``` if (typeof document !== 'undefined') { const { default: ButtonJS } = await import( /*...
The OGL statement in the footer had an additional space before the comma - need to investigate why the html diffing tests did not pick this up, to ensure we...
Current gov examples don't demo things like change handlers, click handlers etc. Would be good to demo some
When auto importing a component in VSCode, /gov is suffixed to component paths. For example `import { Button } from 'govuk-react-jsx/govuk'` but this isn't necessary. Need to investigate where this...
When releasing a build from a tag, check git tag version matches that in package.json in TravisCI - to prevent the two getting out of step. Git tags can be...
At the moment the test suite runs against the source files but for additional confidence I wonder if we should be running the test suite against the build output -...
As per the discussion in #36 - consider whether to include components for grid and typography like headings and paragraphs. Hadn't initially included these since they weren't "components" per se,...
Consider onBlur, onInput and other form field specific events for DateInput, Radios and Checkboxes. Since these components are effectively "compound" fields, we don't by default spread the top level props...
As per the comment at https://github.com/surevine/govuk-react-jsx/issues/45#issuecomment-587084404 it is not immediately clear upon viewing the storybook that you can pass components to children props and not just html. The html in...
Using the date input with a form library like Formik causes problems because it is not able to handle a top level value prop. You need to wrap the component...