govuk-react-jsx icon indicating copy to clipboard operation
govuk-react-jsx copied to clipboard

Consider hand crafting the storybook demos instead of using govuk examples (Relegating these to tests only)

Open andymantell opened this issue 5 years ago • 0 comments

As per the comment at https://github.com/surevine/govuk-react-jsx/issues/45#issuecomment-587084404 it is not immediately clear upon viewing the storybook that you can pass components to children props and not just html. The html in the demos is technically in JSX form, implying that components could be used also but it's very easy to miss that and just see html.

Might be worth considering hand crafting a smaller set of clearer demos, and relegating the govuk examples to the test suite only.

andymantell avatar Feb 18 '20 08:02 andymantell