Andy Holmes

Ah, so it's more like "defer" then. Well, I guess that can be cleaned up later, not very much of GSConnect was written to support modern async features so this...

> Some tests are inexplicably failing and I haven't been able to figure out why, it's because the `mockComponents` function seems to not work (properties simply disappear from the object...

~~Okay, so it looks like some of the paths just might not be pointing to the correct parent, like~~. https://github.com/GSConnect/gnome-shell-extension-gsconnect/blob/3443e2767fcbfa795e8da7acc3767b1596e49c9f/installed-tests/suites/backends/testLanBackend.js#L8 ~~Which I believe should be `../../fixtures/utils.js`?~~ EDIT: sorry, I forgot...

Okay, this does help: ```diff diff --git a/installed-tests/fixtures/components/index.js b/installed-tests/fixtures/components/index.js index 7d128e11..29d4fec7 100644 --- a/installed-tests/fixtures/components/index.js +++ b/installed-tests/fixtures/components/index.js @@ -2,12 +2,12 @@ // // SPDX-License-Identifier: GPL-2.0-or-later -export {default as clipboard} from './clipboard.js';...

Ah, you're right: https://github.com/GSConnect/gnome-shell-extension-gsconnect/blob/43594cc23826fdc6b17acd04b67b34338acf78d4/installed-tests/meson.build#L29-L41 That should setup tests correctly for the uninstalled case. Then each suite should setup the rest for installed tests: https://github.com/GSConnect/gnome-shell-extension-gsconnect/blob/43594cc23826fdc6b17acd04b67b34338acf78d4/installed-tests/suites/core/meson.build#L28-L43

Considering the amount of work that went into this, and the fact the test suite is pretty dusty anyways, how do we feel about just pushing forward after a re-base?...

Oops, I thought I left a comment here. Feel free to un-Draft when you're ready for merge. Should it be merged after the GNOME 46 release, or just in time?

> The tests are running fine installed currently after applying https://github.com/GSConnect/gnome-shell-extension-gsconnect/pull/1683#issuecomment-1963095964 ( 🎉 ), only running into an issue with one of the clipboard plugin tests and the MPRIS component...

The MPRIS tests are useful, because it's one the plugins associated with a specification, but honestly most players don't implement it properly anyways (I think the Rust crate floating around...

Just need those two remaining dead code bits removed, and looks good to merge :+1: