Andy Balaam

Results 205 comments of Andy Balaam

I've asked the design team to take a look at this. Code-wise, after a brief look, it looks pretty sane to me. Thanks for working on this!

Looks like some type check is complaining @jaiwanth-v

I had a quick chat with the team and apparently this is something @ara4n has asked for over a reasonably long period of time.

> @andybalaam it should be fixed now. Yep. Let's see what @janogarcia says about this, and then I'll get into reading the code properly.

> @andybalaam Can I have an exception from the final failing linting step? Adding more testing at this point feels arbitrary. Can we have a test of what happens when...

Also, this smell might be valid? ![image](https://github.com/matrix-org/matrix-react-sdk/assets/76812/927ce562-b665-473f-a11c-0b8fad6d26df)

``` $ tsc --noEmit --jsx react && tsc --noEmit --jsx react -p cypress Error: node_modules/@vector-im/compound-web/dist/components/Tooltip/Tooltip.d.ts(43,164): error TS2694: Namespace 'React' has no exported member 'JSX'. ```

I think the react-types change might have broken this, so updating and trying again now that has been reverted.

``` Error: src/utils/MessageDiffUtils.tsx(149,84): error TS2749: 'DiffMatchPatch' refers to a value, but is being used as a type here. Did you mean 'typeof DiffMatchPatch'? ```

The lint failure was caused by https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/66677 - I opened that and hope to see a fix.