matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Link directly to a user's profile in the e2ee room card

Open anoadragon453 opened this issue 1 year ago • 3 comments

Checklist

  • [x] Tests written for new code (and old code if feasible)
  • [ ] Linter and other CI checks pass
  • [x] Sign-off given on the changes (see CONTRIBUTING.md)

Description

This PR updates the subtitle of the "Encryption Enabled" card that appears at the top of end-to-end encrypted DMs to link directly to a user's profile, instead of asking the user to "tap" around to open it.

Old:

image

New:

image

Changelog

Notes: Provide a link to a user's profile in the "Encryption Enabled" room card, instead of asking the user to navigate themselves

Type: enhancement

Sign-off

Signed-off-by: Andrew Morgan <[email protected]>

Here's what your changelog entry will look like:

✨ Features

  • Provide a link to a user's profile in the "Encryption Enabled" room card, instead of asking the user to navigate themselves (#11497).

anoadragon453 avatar Aug 31 '23 09:08 anoadragon453

@andybalaam Can I have an exception from the final failing linting step? Adding more testing at this point feels arbitrary.

anoadragon453 avatar Sep 07 '23 16:09 anoadragon453

@andybalaam Can I have an exception from the final failing linting step? Adding more testing at this point feels arbitrary.

Can we have a test of what happens when you can't fetch the DM partner's details? That seems legit to me, and should bump you over the threshold...

andybalaam avatar Sep 07 '23 16:09 andybalaam

Also, this smell might be valid?

image

andybalaam avatar Sep 07 '23 16:09 andybalaam

Sorry @anoadragon453 at this point this would need some work to revive plus need design review. This area of the app is scheduled for redesign as part of the Trust & Decoration project.

t3chguy avatar Jul 25 '24 09:07 t3chguy

Oops, this had completely fallen off my radar. Thanks for addressing, and no worries!

anoadragon453 avatar Jul 25 '24 11:07 anoadragon453