Andy Balaam
Andy Balaam
Thank you for the contribution! To merge this we would need: * A clear description of what it does in the PR * A code change adding a toast to...
Yes, it is still open.
@stas-demydiuk I am so sorry for the long delay to this PR. Thank you for writing it, and following up multiple times. We picked up the fact that we had...
Closed in favour of https://github.com/matrix-org/matrix-js-sdk/pull/4107
> > The correct order to use is the order in which they are provided during the sync request from the homeserver. > > What about when you have events...
> Related [matrix-org/matrix-spec#852](https://github.com/matrix-org/matrix-spec/issues/852) > > > I'm not sure, but in principle I think the answer is that we should keep hold of our current best guess of the order...
lol. I asked in the matrix spec room: [link to message](https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$5bfXdRchqYJBzKcVJ1cJdtGNcvWlf3M3G1g9bOSIOcU?via=matrix.org&via=libera.chat&via=element.io)
I was encouraged to log an issue against the spec, so I did that here: https://github.com/matrix-org/matrix-spec/issues/1503
> Does this relate as well? https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/models/thread.ts#L257 Yes
Hmm. Since IPushRules is an interface, and `device` is optional, maybe this is not a breaking change. I'll wait for comment from someone with more context.