matrix-js-sdk
matrix-js-sdk copied to clipboard
matrix-org
Several places in the code use timestamp to determine event order
When are processing events, we sometimes need to know what order they are in. (For example, to decide whether an event is before the last read receipt so we know whether a room is unread.)
The correct order to use is the order in which they are provided during the sync request from the homeserver. It is the homeserver's job to determine a linear order from the DAG, and we need to agree with the homeserver to make sure we are giving the correct results for e.g. the notifications for a room.
In some places in the code we use the timestamp (ts property) of events to determine their order, because we don't have a record of the order of events from sync.
We should keep track of the server-provided event order and replace all uses of ts with the correct order. In the meantime, if we add code that depends on ts, we should reference this issue in a comment in the code.
Impact of this issue: sometimes there may be stuck unreads or notifications due to inconsistencies between how the homeserver and the client understand the order of events. This may also cause other problems - we're not certain. We think the problems we see will be relatively rare, which is why this has not yet been fixed.
The correct order to use is the order in which they are provided during the sync request from the homeserver.
What about when you have events from /context/ which follows a different ordering? Similar question for /relations/.
The correct order to use is the order in which they are provided during the sync request from the homeserver.
What about when you have events from
/context/which follows a different ordering? Similar question for/relations/.
I'm not sure, but in principle I think the answer is that we should keep hold of our current best guess of the order the server has, even if sometimes it's not 100% correct.
In future we might need to figure out an MSC that makes this easier to deal with.
Related https://github.com/matrix-org/matrix-spec/issues/852
I'm not sure, but in principle I think the answer is that we should keep hold of our current best guess of the order the server has, even if sometimes it's not 100% correct.
The server has 2 main orderings though, topological ordering and stream ordering, which do you propose we try and guess? Some APIs return one, some the other. They do not fit within the same total order.
Related matrix-org/matrix-spec#852
I'm not sure, but in principle I think the answer is that we should keep hold of our current best guess of the order the server has, even if sometimes it's not 100% correct.
The server has 2 main orderings though, topological ordering and stream ordering, which do you propose we try and guess? Some APIs return one, some the other. They do not fit within the same total order.
I can't find the answer in the spec but my current belief is that we need stream order to handle read receipts correctly. Do you have an opinion?
I was encouraged to log an issue against the spec, so I did that here: https://github.com/matrix-org/matrix-spec/issues/1503
Does this relate as well? https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/models/thread.ts#L257
Does this relate as well? https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/models/thread.ts#L257
Yes